Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix R linting job (fixes #3873) #3877

Merged
merged 4 commits into from
Jan 28, 2021
Merged

[ci] fix R linting job (fixes #3873) #3877

merged 4 commits into from
Jan 28, 2021

Conversation

jameslamb
Copy link
Collaborator

Attempting to fix #3873.

Warning message:
package ‘lintr’ was built under R version 3.6.3
[1] 49 R files need linting
Error in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]) :
namespace ‘xfun’ 0.15 is being loaded, but >= 0.19 is required
Calls: ... namespaceImportFrom -> asNamespace -> loadNamespace
Execution halted

There might be a mistake somewhere in lintr's feedstock on conda-forge or in one of its dependencies. {xfun} is not a direct dependency of {lintr} (https://github.com/conda-forge/r-lintr-feedstock/blob/master/recipe/meta.yaml), so it must be a dependency of a dependency (or deeper 😆 ). For now, I'm just going to try forcing conda install to get a newer version.

@jameslamb
Copy link
Collaborator Author

It seems like this fix did fix the lint job! https://github.com/microsoft/LightGBM/pull/3877/checks?check_run_id=1785176162

@jameslamb jameslamb marked this pull request as ready for review January 28, 2021 15:40
@jameslamb jameslamb removed the request for review from Laurae2 January 28, 2021 15:41
jameslamb
jameslamb commented Jan 28, 2021
View reviewed changes
.ci/test.sh Outdated Show resolved Hide resolved
StrikerRUS
StrikerRUS approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StrikerRUS
Copy link
Collaborator

Should we report this in conda-forge repo?

@jameslamb
Copy link
Collaborator Author

Should we report this in conda-forge repo?

yes, I will

@jameslamb
Copy link
Collaborator Author

should we report this in the conda-forge repo

Created conda-forge/r-lintr-feedstock#12

@jameslamb
Copy link
Collaborator Author

It seems that lint is passing, and all other CI jobs are passing except the ones we know are broken and waiting on other PRs (#3876 (comment)), so I'm going to merge this.

@jameslamb jameslamb merged commit 6c9d0c3 into master Jan 28, 2021
@jameslamb jameslamb deleted the fix/r-lint-job branch January 28, 2021 18:58
This was referenced Jan 28, 2021
Merged
Merged
@StrikerRUS
Copy link
Collaborator

@jameslamb

Created conda-forge/r-lintr-feedstock#12

Thank you very much! Hope this will allow us revert the workaround eventually.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R-lintr failures at CI
2 participants
@jameslamb @StrikerRUS